fix: Select component highlighted text color#7196
Merged
bmuenzenmeyer merged 1 commit intonodejs:mainfrom Nov 7, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
fast tracking this - this is broken in production |
github-actions
Bot
removed
the
github_actions:pull-request
Contributor
Unit Test Coverage Report
Unit Test Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the update made in the PR #7179, the theme strategy was changed from
classtoselector.This gives the styling given to the attribute more priority than the styling given to the class. With this PR, a highlighted text color for dark mode was added to the Select component
Validation
In the preview build highlighted text should be visible
Related Issues
fixes #7185
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.